Skip to content

Improved Arrow Tip Showcase example for :class:.ArrowTip #3297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 20, 2023
Merged

Improved Arrow Tip Showcase example for :class:.ArrowTip #3297

merged 1 commit into from
Jul 20, 2023

Conversation

@teraspora
Copy link
Contributor

@teraspora teraspora commented Jul 17, 2023

Overview: What does this pull request change?

  • Improve an example in the docstring for the ArrowTip class, by
  1. Adding an example of the new StealthTip
  2. Adding smaller-scale versions for all tips,
  3. Adjusting the layout

Motivation and Explanation: Why and how do your changes improve the library?

Links to added or changed documentation pages

Further Information and Comments

Reviewer Checklist

  • The PR title is descriptive enough for the changelog, and the PR is labeled correctly
  • If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
  • If applicable: newly added functions and classes are tested

@behackl behackl added the documentation Improvements or additions to documentation label Jul 17, 2023
behackl
behackl approved these changes Jul 17, 2023
View reviewed changes
Copy link
Member

@behackl behackl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a fine improvement, thank you! I've left one comment, please take a look.

@behackl behackl merged commit 658f1b4 into ManimCommunity:main Jul 20, 2023
@behackl behackl changed the title Improve Arrow Tip Showcase example in docstring of class ArrowTip Improved Arrow Tip Showcase example for :class:.ArrowTip Jul 20, 2023
@behackl behackl added this to the v0.18.0 milestone Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@behackl behackl behackl approved these changes

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

v0.18.0

Development

Successfully merging this pull request may close these issues.

2 participants

@teraspora @behackl